Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the capability for controller level checks #285

Merged
merged 6 commits into from
May 18, 2020
Merged

Add the capability for controller level checks #285

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3a295ed
Add controller level checks
baderbuddy May 11, 2020
29eefce
Add check for multipleReplicas
baderbuddy May 11, 2020
413acd6
Fixed spec
baderbuddy May 11, 2020
0b090fd
Add controller level check
baderbuddy May 18, 2020
7d1fa01
Merge branch 'master' into bb/controller-checks
May 18, 2020
2bfbf13
Move controller schema checks to their own function.
baderbuddy May 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed spec
  • Loading branch information
@baderbuddy
baderbuddy committed May 11, 2020
commit 413acd6e5718d8cb0476cbe3c60beb9521e9d813
19 changes: 12 additions & 7 deletions checks/multipleReplicasForDeployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,19 @@ controllers:
schema:
'$schema': http://json-schema.org/draft-07/schema
type: object
required:
- spec
required:
- Object
properties:
spec:
Object:
type: object
required:
- replicas
- spec
properties:
replicas:
type: integer
minimum: 2
spec:
type: object
required:
- replicas
properties:
replicas:
type: integer
minimum: 2
2 changes: 2 additions & 0 deletions examples/config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
checks:
# reliability
multipleReplicasForDeployment: warning
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move this to examples/config-full.yaml?

I think there are legitimate reasons to only have 1 replica (e.g. the polaris dashboard itself runs with 1 replica), but we could add this as an "optional check".

I'd love to build up a big community-driven library of checks that people could opt in or out of.

# resources
cpuRequestsMissing: warning
cpuLimitsMissing: warning
Expand Down