-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for more controller versions #245
Conversation
Codecov Report
@@ Coverage Diff @@
## master #245 +/- ##
==========================================
- Coverage 56.31% 51.66% -4.66%
==========================================
Files 12 12
Lines 641 753 +112
==========================================
+ Hits 361 389 +28
- Misses 243 309 +66
- Partials 37 55 +18
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. just had one question.
pkg/kube/resources.go
Outdated
return nil, err | ||
} | ||
jobs, err := kube.BatchV1().Jobs("").List(listOpts) | ||
daemonSets, err := kube.AppsV1().DaemonSets("").List(listOpts) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could this use getDaemonSets
too? I think you will still miss appsv1beta2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! I added some tests to make sure we don't miss these.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks Robert
Fixes #244
The most disruptive change here is that if building the webhook fails, we don't exit the process. This way if we try to watch a type/version that's not available in the cluster, it won't fail to start.