Add support for more controller versions #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #245 +/- ##
==========================================
- Coverage 56.31% 51.66% -4.66%
==========================================
Files 12 12
Lines 641 753 +112
==========================================
+ Hits 361 389 +28
- Misses 243 309 +66
- Partials 37 55 +18
Continue to review full report at Codecov.
|
makoscafee
reviewed
Feb 26, 2020
pkg/kube/resources.go
Outdated
| return nil, err | ||
| } | ||
| jobs, err := kube.BatchV1().Jobs("").List(listOpts) | ||
| daemonSets, err := kube.AppsV1().DaemonSets("").List(listOpts) |
There was a problem hiding this comment.
could this use getDaemonSets too? I think you will still miss appsv1beta2
There was a problem hiding this comment.
Good catch! I added some tests to make sure we don't miss these.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #244
The most disruptive change here is that if building the webhook fails, we don't exit the process. This way if we try to watch a type/version that's not available in the cluster, it won't fail to start.