Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change webhook language to admission controller #242

Merged
merged 1 commit into from
Feb 21, 2020

Conversation

ejether
Copy link

@ejether ejether commented Feb 18, 2020

updating language around the webhook because admission controller is what people are really searching for, not webhook

…hat people are really searching for, not webook
@claassistantio
Copy link

claassistantio commented Feb 18, 2020

CLA assistant check
All committers have signed the CLA.

@ejether ejether requested a review from kenm47 February 18, 2020 01:10
@ejether
Copy link
Author

ejether commented Feb 18, 2020

CLA Assistant.. do you know who I am?

@codecov
Copy link

codecov bot commented Feb 18, 2020

Codecov Report

Merging #242 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #242   +/-   ##
=======================================
  Coverage   56.31%   56.31%           
=======================================
  Files          12       12           
  Lines         641      641           
=======================================
  Hits          361      361           
  Misses        243      243           
  Partials       37       37

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4457293...c64ba4b. Read the comment docs.

@rbren
Copy link
Contributor

rbren commented Feb 18, 2020

Agreed!

@rbren rbren merged commit 6213291 into master Feb 21, 2020
@rbren rbren deleted the ejether/rework-webhook-language branch February 21, 2020 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants