Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for third-party Controllers (e.g. OpenShift) #240

Merged
merged 26 commits into from
Mar 26, 2020
Merged

Adding support for third-party Controllers (e.g. OpenShift) #240

Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
330d7f0
Add note about config change
Jan 31, 2020
51d639e
Prevent divide by 0
Jan 31, 2020
aaa54cc
Directly return 0 for divide by 0
Jan 31, 2020
31de106
Added check for parent and rollup to parent.
Jan 31, 2020
b5ac0bc
Merge branch 'master' into bb/openshift
Feb 3, 2020
619e17d
Merge branch 'master' into bb/openshift
Feb 19, 2020
fe55216
Merge branch 'master' into bb/openshift
Mar 16, 2020
bb34be7
Dynamically retrieve parents
baderbuddy Mar 16, 2020
0d3fe61
Remove unnecessary queries
baderbuddy Mar 16, 2020
7fdebfc
Fix tests
baderbuddy Mar 17, 2020
3c68527
Cut out logic specific to controller types
baderbuddy Mar 17, 2020
8c769e4
Cut out duplicitive code.
baderbuddy Mar 17, 2020
fb0d7c5
Add additional logging
baderbuddy Mar 17, 2020
c43ace2
Add support for CronJobs in support versions list
baderbuddy Mar 17, 2020
61ecb69
Adding support for v2alpha1 for cron
baderbuddy Mar 17, 2020
ee2ccb0
Merge branch 'master' into bb/openshift
Mar 17, 2020
98533bc
Merge branch 'master' into bb/openshift
Mar 18, 2020
d18bf85
Merge branch 'master' into bb/openshift
Mar 19, 2020
68fe230
Feedback from PR
baderbuddy Mar 23, 2020
49dbd1d
Merge branch 'bb/openshift' of github.com:FairwindsOps/polaris into b…
baderbuddy Mar 23, 2020
aa0658b
Merge branch 'master' into bb/openshift
Mar 23, 2020
5769acf
deduplicate results right away
baderbuddy Mar 25, 2020
a5828a2
Fix tests
baderbuddy Mar 25, 2020
3c46f40
Cleanup SupportedControllers
baderbuddy Mar 25, 2020
dcf02b9
Merge branch 'master' into bb/openshift
Mar 25, 2020
57f3a8b
Merge branch 'master' into bb/openshift
Mar 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Adding support for v2alpha1 for cron
  • Loading branch information
@baderbuddy
baderbuddy committed Mar 17, 2020
commit 61ecb69ab1e172301fd411361a1f64ad5c7de80f
2 changes: 2 additions & 0 deletions pkg/config/supportedcontrollers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import (
appsv1beta2 "k8s.io/api/apps/v1beta2"
batchv1 "k8s.io/api/batch/v1"
batchV1beta1 "k8s.io/api/batch/v1beta1"
baderbuddy marked this conversation as resolved.
Show resolved Hide resolved
batchv2alpha1 "k8s.io/api/batch/v2alpha1"
corev1 "k8s.io/api/core/v1"
"k8s.io/apimachinery/pkg/runtime"
)
Expand Down Expand Up @@ -126,6 +127,7 @@ func (s SupportedController) ListSupportedAPIVersions() []runtime.Object {
case CronJobs:
supportedVersions = []runtime.Object{
&batchV1beta1.CronJob{},
&batchv2alpha1.CronJob{},
}
case ReplicationControllers:
supportedVersions = []runtime.Object{
Expand Down