Fixes for linting, updating CI to fail when linting does #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robscott
force-pushed
the
rs/fix-linting
branch
from
e8f0d8b
to
f2211ed
Compare
| @@ -4,10 +4,12 @@ import ( | |||
| "fmt" | |||
|
|
|||
| "k8s.io/client-go/kubernetes" | |||
| // Required for GKE auth | |||
There was a problem hiding this comment.
is this too nit-picky?... I like all comments to have proper grammar so they end with a period
robscott
force-pushed
the
rs/fix-linting
branch
from
f2211ed
to
535735f
Compare
JessicaGreben
approved these changes
Feb 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #23. A side effect of these changes involved updating the JSON endpoint to return the same data that powers the dashboard.