JSON schema checks #234
JSON schema checks #234
Conversation
rbren
changed the title
…ris into rb/custom-checks
Codecov Report
@@ Coverage Diff @@
## master #234 +/- ##
=========================================
- Coverage 79.21% 71.31% -7.9%
=========================================
Files 12 13 +1
Lines 765 781 +16
=========================================
- Hits 606 557 -49
- Misses 134 186 +52
- Partials 25 38 +13
Continue to review full report at Codecov.
|
|
In the interest of keeping changes small, I'm going to cut this PR here. Future work:
|
|
Also note: while this PR is backward-compatible, this will likely get released as a major version update. |
| cv.validateHealthChecks(conf, controllerName) | ||
|
|
||
| err := applyContainerSchemaChecks(conf, controllerName, controllerType, &cv) | ||
| // FIXME: don't panic |
There was a problem hiding this comment.
Assuming this was left on purpose to be fixed in separate PR right?
There was a problem hiding this comment.
Yup - I've got another PR coming in after this one, and probably one more refactor after that.
| } | ||
| } | ||
| } | ||
|
|
||
| func (cv *ContainerValidation) validateSecurity(conf *config.Configuration, controllerName string) { |
There was a problem hiding this comment.
Not sure I understand why is only validate security is left here ...?
There was a problem hiding this comment.
The capabilities check is harder to implement in JSON schema, so I'm leaving it here for now. It'll be gone in the next PR.
This is step 1 toward supporting custom checks written in JSON schema.
I think rewriting many of our current checks using JSON schema will help clean up the codebase a bunch too.