-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add exemptions to config #204
Conversation
2eee7b6
to
77ae237
Compare
Codecov Report
@@ Coverage Diff @@
## master #204 +/- ##
=========================================
- Coverage 81.15% 79.3% -1.85%
=========================================
Files 11 12 +1
Lines 711 749 +38
=========================================
+ Hits 577 594 +17
- Misses 107 130 +23
+ Partials 27 25 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this is definitely a huge +1 - some stuff to chat about in the future but for now this seems to satisfy the need, assuming we're ok with the accidental exemption issue noted in my previous comment.
Good points! Thanks for the review. Can definitely try and hit some of these (esp failing on invalid names) in a future PR. |
No description provided.