Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wl/stored audits #188

Merged
merged 16 commits into from
Aug 14, 2019
Merged

Wl/stored audits #188

merged 16 commits into from
Aug 14, 2019

Conversation

willfairwinds
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Aug 8, 2019

Codecov Report

Merging #188 into master will decrease coverage by 2.48%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #188      +/-   ##
==========================================
- Coverage   82.84%   80.35%   -2.49%     
==========================================
  Files          10       10              
  Lines         647      667      +20     
==========================================
  Hits          536      536              
- Misses         87      107      +20     
  Partials       24       24
Impacted Files Coverage Δ
pkg/validator/types.go 73.8% <0%> (-23.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15b1455...d34be89. Read the comment docs.

pkg/dashboard/dashboard.go Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
pkg/dashboard/dashboard.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
main.go Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
@rbren
Copy link
Contributor

rbren commented Aug 14, 2019

Looks good! Just remove the file at pkg/test.json

Also don't forget to use "Squash and Merge" :)

@willfairwinds willfairwinds merged commit b8422a9 into master Aug 14, 2019
@willfairwinds willfairwinds deleted the wl/stored-audits branch August 14, 2019 21:20
@endzyme
Copy link
Contributor

endzyme commented Aug 14, 2019

Oops looks like this was already merged while i was looking at it - no worries 👍 :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants