Wl/webhook test #182
Wl/webhook test #182
Conversation
willfairwinds
requested review from
rbren,
endzyme,
kimschles and
robscott
as code owners
Codecov Report
@@ Coverage Diff @@
## master #182 +/- ##
=======================================
Coverage 82.84% 82.84%
=======================================
Files 10 10
Lines 647 647
=======================================
Hits 536 536
Misses 87 87
Partials 24 24Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Looks great! We just have to add these tests to CircleCI to get them to run every time someone submits a pull request.
To do this, you'll want to edit ./.circleci/config.yml:
- add an
install_kindsection toreferences, with the commands necessary to install KIND - add the lines
* install_kindandrun: ./test/webhook_test.shto thetestjob
I think that should do it!
…in webhook_test.sh
test/webhook_test.sh
Outdated
| echo "Webhook started!" | ||
| } | ||
|
|
||
| function check_dashboard_is_ready() { |
There was a problem hiding this comment.
I think you can get rid of this now
test/webhook_test.sh
Outdated
|
|
||
| # Install the webhook and dashboard | ||
| kubectl apply -f ./deploy/webhook.yaml &> /dev/null | ||
| kubectl apply -f ./deploy/dashboard.yaml &> /dev/null |
test/webhook_test.sh
Outdated
|
|
||
| # wait for the webhook and dashboard to come online | ||
| check_webhook_is_ready | ||
| check_dashboard_is_ready |
| @@ -130,7 +130,8 @@ jobs: | |||
| steps: | |||
| - checkout | |||
| - *install_k8s | |||
| - *test_kube_dashboard | |||
There was a problem hiding this comment.
You can get rid of test_kube_dashboard above now
| timeout_epoch=$(date -d "+2 minutes" +%s) | ||
| echo "Waiting for dashboard to be ready" | ||
| while ! kubectl get pods -n polaris | grep -E "dashboard.*1/1.*Running"; do | ||
| echo -n "." |
There was a problem hiding this comment.
I think you need a check_timeout "${timeout_epoch}" above this
No description provided.