Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add exit code flag #155

Merged
merged 4 commits into from
Jun 24, 2019
Merged

Add exit code flag #155

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3fd3c04
[WIP] add exit-code flag
kimschles Jun 21, 2019
1b5557d
add functionality for --exit-code flag
kimschles Jun 24, 2019
29261ed
rename flag and change logrus error to info
kimschles Jun 24, 2019
9b755b8
move setExitCode logic to bottom of function
kimschles Jun 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ func main() {
webhook := flag.Bool("webhook", false, "Runs the webhook webserver.")
audit := flag.Bool("audit", false, "Runs a one-time audit.")
auditPath := flag.String("audit-path", "", "If specified, audits one or more YAML files instead of a cluster")
setExitCode := flag.Bool("set-exit-code-on-error", false, "set an exit code of 2 when the audit contains error-level issues.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heads up - this doc doesn't match the os.Exit(3) used below. Also, any consideration on just using 1 as the exit code?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix.

We decided against 1 so that we could differentiate this expected failure from unexpected failures.

dashboardPort := flag.Int("dashboard-port", 8080, "Port for the dashboard webserver")
dashboardBasePath := flag.String("dashboard-base-path", "/", "Path on which the dashboard is served")
webhookPort := flag.Int("webhook-port", 9876, "Port for the webhook webserver")
Expand Down Expand Up @@ -95,7 +96,7 @@ func main() {
} else if *dashboard {
startDashboardServer(c, *auditPath, *dashboardPort, *dashboardBasePath)
} else if *audit {
runAudit(c, *auditPath, *auditOutputFile, *auditOutputURL, *auditOutputFormat)
runAudit(c, *auditPath, *setExitCode, *auditOutputFile, *auditOutputURL, *auditOutputFormat)
}
}

Expand Down Expand Up @@ -180,7 +181,7 @@ func startWebhookServer(c conf.Configuration, disableWebhookConfigInstaller bool
}
}

func runAudit(c conf.Configuration, auditPath string, outputFile string, outputURL string, outputFormat string) {
func runAudit(c conf.Configuration, auditPath string, setExitCode bool, outputFile string, outputURL string, outputFormat string) {
k, err := kube.CreateResourceProvider(auditPath)
if err != nil {
logrus.Errorf("Error fetching Kubernetes resources %v", err)
Expand Down Expand Up @@ -253,4 +254,9 @@ func runAudit(c conf.Configuration, auditPath string, outputFile string, outputU
}
}
}

if setExitCode && auditData.ClusterSummary.Results.Totals.Errors > 0 {
logrus.Infof("Error found. Exiting audit.")
os.Exit(3)
}
}