Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak CI for forked PRs and better release process #115

Merged
merged 3 commits into from
Jun 7, 2019
Merged

Tweak CI for forked PRs and better release process #115

merged 3 commits into from
Jun 7, 2019

Conversation

rbren
Copy link
Contributor

@rbren rbren commented May 20, 2019

Two changes here:

  • Builds a new docker image after a tag is created, so we don't have to wait for the previous merge-commit CI to finish
  • Skips docker push and codecov updates on forked PRs, as secrets are not available

@rbren rbren requested a review from robscott as a code owner May 20, 2019 12:59
@rbren rbren requested a review from coreypobrien May 28, 2019 12:40
@ejether
Copy link

ejether commented May 30, 2019

Would it make sense to integrate rok8s scripts into this ci process?

@rbren
Copy link
Contributor Author

rbren commented Jun 3, 2019

I'm not sure. @sudermanjr any thoughts?

@endzyme endzyme self-requested a review June 3, 2019 17:33
endzyme
endzyme approved these changes Jun 7, 2019
View reviewed changes
Copy link
Contributor

@endzyme endzyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems pretty straight forward. The only implication is we're building the docker image twice but seems like a fine trade for not getting pipeline failures when tagging.

@rbren rbren requested a review from kimschles as a code owner June 7, 2019 17:39
@rbren rbren merged commit 0bd8f8f into master Jun 7, 2019
@rbren
Copy link
Contributor Author

rbren commented Jun 7, 2019

Also enabled CircleCI on forked PRs in the CircleCI settings. Thanks!

@endzyme endzyme deleted the rb/ci branch July 3, 2019 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@endzyme endzyme endzyme approved these changes

@robscott robscott Awaiting requested review from robscott

@coreypobrien coreypobrien Awaiting requested review from coreypobrien

@kimschles kimschles Awaiting requested review from kimschles

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rbren @ejether @endzyme