Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readiness probes should be ignored on initContainers #112

Closed
irasnyd opened this issue May 17, 2019 · 1 comment · Fixed by #121
Closed

Readiness probes should be ignored on initContainers #112

irasnyd opened this issue May 17, 2019 · 1 comment · Fixed by #121
Labels
bug Something isn't working

Comments

@irasnyd
Copy link

irasnyd commented May 17, 2019 •
edited
Loading

The Kubernetes documentation states that readiness probes are not supported on initContainers:

https://kubernetes.io/docs/concepts/workloads/pods/init-containers/

Also, Init Containers do not support readiness probes because they must run to completion before the Pod can be ready.

Based on this, I think that lack of a readiness probe should be ignored for initContainers. This would bring my cluster's score up a bit. 😃
@robscott robscott added the bug Something isn't working label May 20, 2019
@robscott
Copy link
Contributor

Great catch, thanks! We'll work on fixing that.

robscott added a commit that referenced this issue May 20, 2019
@robscott
ensuring that readiness probes in init containers are not validated to …
b1e9559 
…fix #112
@robscott robscott mentioned this issue May 20, 2019
Merged
robscott added a commit that referenced this issue May 20, 2019
@robscott
ensuring that readiness probes in init containers are not validated to …
f5c7087 
…fix #112
@sudermanjr sudermanjr mentioned this issue Oct 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensuring that readiness probes in init containers are not validated FairwindsOps/polaris
2 participants
@robscott @irasnyd