don't exit if webhook registration fails

FairwindsOps · Feb 25, 2020 · dad5262 · dad5262
1 parent c591765
commit dad5262
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/cmd/polaris/webhook.go b/cmd/polaris/webhook.go
@@ -106,7 +106,9 @@ var webhookCmd = &cobra.Command{
 			for innerIndex, supportedAPIType := range controllerToScan.ListSupportedAPIVersions() {
 				webhookName := strings.ToLower(fmt.Sprintf("%s-%d-%d", controllerToScan, index, innerIndex))
 				hook := fwebhook.NewWebhook(webhookName, mgr, fwebhook.Validator{Config: config}, supportedAPIType)
-				webhooks = append(webhooks, hook)
+				if hook != nil {
+					webhooks = append(webhooks, hook)
+				}
 			}
 		}
 

diff --git a/pkg/webhook/validator.go b/pkg/webhook/validator.go
@@ -80,7 +80,7 @@ func NewWebhook(name string, mgr manager.Manager, validator Validator, apiType r
 		Build()
 	if err != nil {
 		logrus.Errorf("Error building webhook: %v", err)
-		os.Exit(1)
+		return nil
 	} else {
 		logrus.Info(name + " webhook started")
 	}