Support LimitRange for current settings.

[MattPOlson]

I've deployed this to an OpenShift 4.6 cluster and if a pods limit/request comes from a LimitRange instead of being defined at the pod/deployment level it's current settings on the dashboard shows as "Not Set"

[sudermanjr]

I converted this to a feature request. LimitRanges are not currently something we support.

[MattPOlson]

Thanks, would it be a big change? Could you point me where in the current code base it would need to be added and I could maybe take a look.

[sudermanjr]

I honestly don't know how hard it would be. I haven't used LimitRanges much at all.

Here is where we pull the current requests and limits -

goldilocks/pkg/summary/summary.go

Lines 184 to 190 in a6988c2

	ContainerName: containerRecommendation.ContainerName,
	UpperBound: utils.FormatResourceList(containerRecommendation.UpperBound),
	LowerBound: utils.FormatResourceList(containerRecommendation.LowerBound),
	Target: utils.FormatResourceList(containerRecommendation.Target),
	UncappedTarget: utils.FormatResourceList(containerRecommendation.UncappedTarget),
	Limits: utils.FormatResourceList(c.Resources.Limits),
	Requests: utils.FormatResourceList(c.Resources.Requests),

Since it's based on the pod spec, I'm not sure how difficult it is going to be to bubble up the settings from the namespace-level object.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[divyanjali1]

@MattPOlson We are looking for a similar solution. Is there any workaround if the limits are taken from Namespace limitranges ?