refactor(Base): Move GetRootManager to FairModule

[ChristianTackeGSI]

... and simplify by using the already existing fRunSim.

---

Checklist:

• Followed the Contributing Guidelines

[coderabbitai]

Walkthrough

Walkthrough

The updates primarily revolve around the modification and removal of methods related to the RootManager in the FairDetector and FairMCApplication classes. Key removals include setting and retrieving the RootManager in FairDetector. The FairMCApplication constructor now initializes the RunSim property, and a new GetRootManager method was introduced in FairModule. These changes enhance the internal management of simulation components, optimizing initialization and registration processes.

Changes

Files	Change Summary
fairroot/base/sim/FairDetector.h	Removed methods SetRootManager and GetRootManager.
fairroot/base/sim/FairMCApplication.cxx	Constructor modified to set RunSim property; RegisterOutput updated to omit RootManager setting.
fairroot/base/sim/FairModule.h	Added new method GetRootManager.
fairroot/base/sim/FairModule.cxx	Added implementation of the new method GetRootManager.

Sequence Diagram(s)

sequenceDiagram
    participant A as User
    participant B as FairMCApplication
    participant C as FairRunSim
    participant D as FairModule
    participant E as FairDetector

    A ->> B: Instantiate FairMCApplication
    B ->> C: Pass runSim during construction
    B ->> D: RegisterOutput()
    D ->> E: Check if detector is active
    alt Detector is active
        E ->> E: Initialize and Register Detector
    else Detector is not active
        E -->> D: Do nothing
    end

Loading

This diagram illustrates the control flow within the FairMCApplication where the user instantiates it, and during the registration of outputs, it checks if detectors are active before initializing and registering them.

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 919383c and aafa926.

Files selected for processing (4)

• fairroot/base/sim/FairDetector.h (2 hunks)
• fairroot/base/sim/FairMCApplication.cxx (2 hunks)
• fairroot/base/sim/FairModule.cxx (1 hunks)
• fairroot/base/sim/FairModule.h (1 hunks)

Files skipped from review as they are similar to previous changes (3)

• fairroot/base/sim/FairDetector.h
• fairroot/base/sim/FairMCApplication.cxx
• fairroot/base/sim/FairModule.cxx

Additional comments not posted (1)

fairroot/base/sim/FairModule.h (1)

191-196: Addition of the GetRootManager method looks good!

The method GetRootManager has been added to retrieve the FairRootManager for the module. Ensure that this method is only called after the module has been added to a FairRunSim, as indicated by the note.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.