feat(base): Introduce FairDetector::GetRootManager#1568
Merged
dennisklein merged 1 commit intoFairRootGroup:devfrom Jul 2, 2024
Merged
feat(base): Introduce FairDetector::GetRootManager#1568dennisklein merged 1 commit intoFairRootGroup:devfrom
dennisklein merged 1 commit intoFairRootGroup:devfrom
Conversation
WalkthroughWalkthroughThe changes primarily involve refactoring the registration methodology within various classes in the codebase to use Changes
Sequence Diagram(s)sequenceDiagram
participant DetectorClass
participant FairRootManager
participant RootManager
DetectorClass ->> RootManager: GetRootManager()
activate RootManager
RootManager ->> DetectorClass: Return RootManager instance
deactivate RootManager
DetectorClass ->> RootManager: Register("CollectionName", "CollectionType", collection, kTRUE)
Recent review detailsConfiguration used: CodeRabbit UI Files selected for processing (17)
Files skipped from review as they are similar to previous changes (16)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
karabowi
previously approved these changes
Jun 25, 2024
Especially classes deriving from FairDetector and implementing the Register member function need access to FairrootManager. Give them a proper getter.
ChristianTackeGSI
force-pushed
the
pr/det_frm
branch
from
8e3a279 to
ec56c6f
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (1)
fairroot/base/steer/FairRootManager.h (1)
139-149: Document deprecation warning clearly forInstance()method.The deprecation warning in the documentation of the
Instance()method is a good practice as it guides the future development towards more maintainable code using specific getters. However, it would be beneficial to include a timeline or condition under which this method will be deprecated to provide clearer guidance to developers.
dennisklein
approved these changes
Jul 2, 2024
1 task
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Especially classes deriving from FairDetector and
implementing the Register member function need access to FairrootManager. Give them a proper getter.
Checklist: