-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start to Refactor Summary Output #1060
Start to Refactor Summary Output #1060
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me, pls remove the heading. The other two remarks are optional, we can delay them to later.
7ba8190
to
8711c78
Compare
Also added CXX standard checking: |
Hmm, looking at the added lines again and thinking about the added value, I am not sure, if I like it. Main goal was to put the typical info which is relevant for the user and in a way that it is easy to learn what are the options one would most likely change from time to time. A secondary goal was to put information which is useful in logs and not shown by CMake by default or not in a compact way easy for the eye. We are now adding 7 questionable lines regarding the goals from above:
This shows how one could save a lot of space for project name and version: Looking at version now, it shows |
ROOT and the package that depend on it should be compiled with the CXX STANDARD. So let's check that CMAKE_CXX_STANDARD matches up with ROOT's setting. Emits warnings for now.
Move Summary Output Generation into functions in a new cmake/private/FairRootSummary.cmake. This is not yet reusable. Goal is to make the main CMakeLists.txt more readable.
* Show Package Name and Version * Show install paths * Little reformatting
8711c78
to
0e96a4a
Compare
Okay, added a lot of STATUS -> VERBOSE in there. $ cmake … --log-level=VERBOSE to see this stuff. Maybe that's better now? I am currently highly considering to add such a flag in our spack recipe "If the user looks at the logs, they want logs". |
Yes, awesome.
Agreed. It is a good idea. |
Refactor the summary output into some functions.
This really only moves the functionality over into functions.
There is one commit with some slight improvments.
Making these things more generic/etc is left for another PR.
Checklist:
dev
branch