Use FairCMakeModules for find_package2 #1059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristianTackeGSI
force-pushed
the
pr/find_package2
branch
from
dbb60bd to
1b417c3
Compare
ChristianTackeGSI
changed the title
dennisklein
reviewed
Apr 25, 2021
dennisklein
changed the title
* Move cmake module installation from main CMakeLists.txt to cmake/ * Only install specific directories from cmake/ * Fix FindFairRoot.cmake to be able to find this again
To make it easier to share find_package2 across projects let's move it into its own file.
Optionally (highly recommended) use FairCMakeModules to provide FairFindPackage2. If FairCMakeModules isn't there, we currently have a fallback mechanism. Fallback sheduled for removal in 19.2.
ChristianTackeGSI
force-pushed
the
pr/find_package2
branch
from
1b417c3 to
91b4976
Compare
dennisklein
approved these changes
Apr 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cmake/)cmake/fallback/find_packageintoFairFindPackage2.cmake(added to fallback directory)Checklist:
devbranch