Skip to content

Commit

Permalink
Deprecate FairRunAnaProof::Instance()
Browse files Browse the repository at this point in the history
To get rid of some of the singleton-like behaviour, start
to deprecate it.
  • Loading branch information
ChristianTackeGSI authored and dennisklein committed Nov 11, 2022
1 parent 585e1a8 commit 29b7cbf
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
* It will be disabled by default in FairRoot 19.
* We plan to remove it completely in FairRoot 20.
* If you need it, speak up NOW.
* Deprecate some singleton-like APIs:
* `FairRunAnaProof::Instance()` - keep a pointer to the
object after `new` in your code.
### Other Notable Changes
* Tests using Geant3 have been disabled by default, because
Expand Down
2 changes: 1 addition & 1 deletion base/steer/FairRunAnaProof.h
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
class FairRunAnaProof : public FairRunAna
{
public:
static FairRunAnaProof* Instance();
[[deprecated]] static FairRunAnaProof* Instance(); ///< \deprecated
virtual ~FairRunAnaProof();
FairRunAnaProof(const char* proofName = "");

Expand Down

0 comments on commit 29b7cbf

Please sign in to comment.