Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include string quotation marks in AtatLen #137

Merged
merged 2 commits into from
Jan 25, 2023

Conversation

rmja
Copy link
Contributor

@rmja rmja commented Jan 10, 2023

This fixes #136

Copy link
Member

@MathiasKoch MathiasKoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
LGTM! 👍

@rmja
Copy link
Contributor Author

rmja commented Jan 25, 2023

@MathiasKoch I fixed the formatting error so I think that this is now ready to merge :)

@MathiasKoch MathiasKoch merged commit a4608e9 into FactbirdHQ:master Jan 25, 2023
maximeborges pushed a commit to yaak-ai/atat that referenced this pull request Sep 5, 2023
* Include string quotation marks in AtatLen

* Formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AT command length computation does not take string quotes into account
2 participants