Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update deps, use fugit_timer::Timer instead of Clocks #113

Merged
merged 1 commit into from
Jan 20, 2022
Merged

update deps, use fugit_timer::Timer instead of Clocks #113

merged 1 commit into from
Jan 20, 2022

Conversation

burrbull
Copy link
Contributor

I've moved Clocks in separate crate as it's too hard to implement it in HALs during this part of atat.
In other side it can't be a part of embedded-hal as fugit primitives are only one of possible solutions.

Copy link
Member

@MathiasKoch MathiasKoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you for you contribution. Looks good to me 👍

I'll bump my dev-dep to E-H v1.0.0-rc6, so the CI can be happy as well.

Cannot wait for E-H to actually release v1.0.0 so it can be properly upstreamed instead.

@burrbull
Copy link
Contributor Author

defmt now use DEFMT_LOG env variable for log level
https://defmt.ferrous-systems.com/migration-02-03.html

@MathiasKoch
Copy link
Member

Yeah, that shouldn't be an issue

@burrbull
Copy link
Contributor Author

Could you rerun CI?

@MathiasKoch
Copy link
Member

@burrbull Would you mind fixing the minor stuff causing examples to fail?
I updated the dev dependency to use embedded-hal v1.0.0-alpha.6, so it should be straight forward now

@burrbull
Copy link
Contributor Author

Should be done

@MathiasKoch
Copy link
Member

Hmm still not completely there.

@MathiasKoch
Copy link
Member

MathiasKoch commented Jan 20, 2022

Just needs an nb or two now.. embedded_hal::serial -> embedded_hal::nb::serial

@burrbull
Copy link
Contributor Author

Try again

@MathiasKoch
Copy link
Member

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants