FR: List All Tutorials For Admins #245
Conversation
Plebysnacc
requested review from
calvalre
and removed request for
dheidemann
| return ( | ||
| <> | ||
| <TutorialPage id={extractId(tutorial) ?? 0} /> | ||
| <TutorialPage eventID={extractId(tutorial) ?? 0} onlyCurrentUser/> |
There was a problem hiding this comment.
i'm not quite sure i get the point behind the onlyCurrentUser? (which somehow also doesn't appear in my code locally which is kinda weird)
There was a problem hiding this comment.
it seems to work as intended without the onlyCurrentUser thing and break if it's in there but i'm not quite sure
There was a problem hiding this comment.
if you leave it out, all users can see all tutorials. I'll look into why it does not fetch correctly
There was a problem hiding this comment.
i feel like it would be beneficial to see what tutor is assigned for which tutorial too (and maybe be able to remove the tutor? tho i dunno if we wanna have that feature)
There was a problem hiding this comment.
i really like the functionality of being able to customize which columns are being shown, however if there is nothing selected you are still able to search and delete students, which shouldn't be possible imo. maybe make it s.t. one column always has to be selected? or remove the delete feature if no column is selected? dunno
| </section> | ||
|
|
||
| <ConfirmationDialog | ||
| description={`Dies wird ${dialogState.currentUser.fn} ${dialogState.currentUser.sn} aus dem Tutorium entfernen`} |
There was a problem hiding this comment.
maybe also include which event the tutorial belongs to? just to have the important info there again
Closes #218