Pull request

[AshrafAbuBakr]

I recommend you'd test it also to make sure things are fine.

[FabrizioBrancati]

Thanks! But can you sync it with master?

[FabrizioBrancati]

When I'll test it, I'll merge!

[AshrafAbuBakr]

Ok
If you find any problems just tell me.

On 12 January 2016 at 11:02, Fabrizio Brancati notifications@github.com
wrote:

Once I've tested it, I'll merge!

—
Reply to this email directly or view it on GitHub
#21 (comment)
.

[FabrizioBrancati]

The LimitedTextFieldDelegate doesn't work, if I want to use the other delegate methods I can't.
We have to create a BFTextField subclass of UITextField, define a BFTextFieldDelegate that extends the UITextFieldDelegate with the maxCharacter property and related methods.

[AshrafAbuBakr]

Yeah you’re right.
I’ll make it a subclass.
Did you face any other problems?

On Jan 16, 2016, at 8:32 PM, Fabrizio Brancati notifications@github.com wrote:

The LimitedTextFieldDelegate doesn't work, if I want to use the other delegate methods I can't.
We have to create a BFTextField subclass of UITextField, define a BFTextFieldDelegate that extends the UITextFieldDelegate with the maxCharacter property and related methods.

—
Reply to this email directly or view it on GitHub #21 (comment).

[FabrizioBrancati]

Sincerly I didn't try the other things, but I've seen that a NSString+BFKit.m.orig and .h.orig has been created, maybe there was conflict.

[AshrafAbuBakr]

I've added BFTextfield as we discussed.
Please check and pull it.
Thank You.

[FabrizioBrancati]

I've test it and something doesn't work, but I'll merge and I'll fix it, don't worry 👍
Thanks!

[AshrafAbuBakr]

May I know what was the problem?

[FabrizioBrancati]

Yes, sorry if I didn't say it to you before.
The main problem was that you has defined the BFTextFieldDelegate with @interface, but delegates aka protocols has to be defined with @protocols.
The other little problems was that you left somethings in other files, like unused variables, that I've removed.
Maybe I've found another method to limit the characters without delegates.
Let me try and see the next commit!

[AshrafAbuBakr]

Ok
Sorry I was very busy I haven't tested it enough.

On 30 January 2016 at 17:23, Fabrizio Brancati notifications@github.com
wrote:

Yes, sorry if I didn't say it to you before.
The main problem was that you has defined the BFTextFieldDelegate with
@interface, but delegates aka protocols has to be defined with @protocols.
The other little problems was that you left somethings in other files,
like unused variables, that I've removed.
Maybe I've found another method to limit the characters without delegates.
Let me try and see the next commit!

—
Reply to this email directly or view it on GitHub
#21 (comment)
.

[FabrizioBrancati]

Don't worry 😉