[1.21.4] Refactor registry sync #4233
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modmuss50
added
in progress
apple502j
suggested changes
Nov 16, 2024
|
|
||
| for (Identifier remoteId : remoteRegistry.keySet()) { | ||
| if (!registry.containsId(remoteId)) { | ||
| // Found a registry entry from the server that is |
Comment on lines
+96
to
+106
| // Registry was not found on the client, is it optional? | ||
| // If so we can just ignore it. | ||
| // Otherwise we throw an exception and disconnect. | ||
| if (registry == null) { | ||
| if (isRegistryOptional(registryId, data)) { | ||
| LOGGER.info("Received registry data for unknown optional registry: {}", registryId); | ||
| continue; | ||
| } else { | ||
| throw new RemapException("Received registry data for unknown registry: " + registryId); | ||
| } | ||
| } |
There was a problem hiding this comment.
I believe this is duplicative, as checkRemoteRemap should've already thrown in this case?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optional registries / stricter defaults
The goal of these changes is to document the expected behaviour of missing registry's when a client connects to a modded server. This behaviour is now consistent between a vanilla clients and modded clients. This has nothing to do with individual registry entries (yet).
Some mods have their own registries that only need to be synced when the connecting client has their mod, I have added a new
OPTIONALregistry attribute that allows this. This attribute is sent in the registry sync packet.The behaviour of a connecting client is as follows:
These changes will only apply to 1.21.4 as they are breaking.
TODO