Defer block entity attachment syncing to match vanilla's sync timing#5178
Merged
modmuss50 merged 12 commits intoFabricMC:26.1from Feb 3, 2026
Merged
Defer block entity attachment syncing to match vanilla's sync timing#5178modmuss50 merged 12 commits intoFabricMC:26.1from
modmuss50 merged 12 commits intoFabricMC:26.1from
Conversation
# Conflicts: # fabric-data-attachment-api-v1/src/main/java/net/fabricmc/fabric/mixin/attachment/BlockEntityMixin.java # fabric-data-attachment-api-v1/src/main/resources/fabric-data-attachment-api-v1.mixins.json
# Conflicts: # fabric-data-attachment-api-v1/src/main/java/net/fabricmc/fabric/mixin/attachment/AttachmentTargetsMixin.java
modmuss50
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently block entity attachments are synced immediately on set, which is fine in most cases but causes problems in some edge cases:
Deferring the sync to match when vanilla syncs solves both of these issues. Current implementation probably needs a bit more testing.
Linked to #5107 and also inspired by Neo's PR for the same issue.