Add transitive access wideners for new Enchantment functional interfaces#5177
Merged
modmuss50 merged 3 commits intoFabricMC:26.1from Feb 3, 2026
Merged
Add transitive access wideners for new Enchantment functional interfaces#5177modmuss50 merged 3 commits intoFabricMC:26.1from
Enchantment functional interfaces#5177modmuss50 merged 3 commits intoFabricMC:26.1from
Conversation
Member
|
You need to modify template.classtweaker and then run generateClassTweaker task with gradle |
Contributor
Author
|
I think that's correct? I put it with the EnchantmentHelper interface wideners |
Patbox
approved these changes
Jan 30, 2026
modmuss50
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At some point during the snapshot cycle
Enchantment#applyEffectswas modified to use the private functional interfacesGenericActionandFloatAction, which made it impossible to use the access-widenedapplyEffectswithout adding your own access wideners. This PR makes those functional interfaces public soapplyEffectscan be used properly.