Make lookup API context extend nullable Object #5172
Merged
modmuss50 merged 1 commit intoFabricMC:26.1from Feb 3, 2026
Merged
Conversation
Contributor
|
why not just mark the context as nullable? it would be much cleaner if possible |
Member
Author
|
Then it will always nullable. You want |
Contributor
Yeah, I would do this, marking the context as potentially Nullable like |
Member
Author
|
That a thing? TIL. I'll take a look later then. |
58ff32b to
a37b367
Compare
Member
Author
|
Extending nullable Object seems to be working. |
modmuss50
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@NullMarkedmakes the lookup contextCnon-nullable by default.This is not ideal since
Ccomes from the usage of the API and thus should allow for null if needed.For example, the transfer API has a nullable
Directioncontext for sided storages.Before
After