Conversation
Member
|
Personally I'm not entirely convinced, see my comments from the original PR:
If people have reason to disagree then we can discuss but I don't think "use name everywhere" is a sensible blanket strategy. |
Member
Author
|
Ah sorry, I must have missed that comment on the other PR. Good point on argsOnly, I think I will change that. I dont think stability across versions is the main goal here if something is renamed/chages its usually done for a reason, and more than likely may cause the mixin to behave differently. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 2 of cherry picking @Earthcomputer 's PR: #5118
Part 3 I will look at the comments on the orginal PR regarding removing unneeded locals, lets keep it focused and merge this one quickly to reduce conflicts.