Skip to content

Add large attachment syncing#5143

Merged
modmuss50 merged 7 commits intoFabricMC:26.1from
DennisOchulor:large-attachment-sync
Jan 29, 2026
Merged

Add large attachment syncing#5143
modmuss50 merged 7 commits intoFabricMC:26.1from
DennisOchulor:large-attachment-sync

Conversation

@DennisOchulor
Copy link
Contributor

This PR mainly does two things:

  1. Change ClientboundAttachmentSyncPayload to handle only one attachment. Initial syncs are sent in a bundle packet.
  2. Allow mods to register synced attachments with a configurable max sync size that can go above the vanilla S2C limit.

Supersedes #4996

Copy link
Member

@modmuss50 modmuss50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just noticed one little thing.

@modmuss50
Copy link
Member

Also a merge conflict, should be an easy fix.

@modmuss50 modmuss50 added enhancement New feature or request status: last call If you care, make yourself heard right away! labels Jan 25, 2026
@DennisOchulor
Copy link
Contributor Author

Quoting @jacobsjo's comment here

It might solve some issues, but not the one I've reported in this issue. This issue is about the very harsh handling of oversized packets, which can happen no matter what the limit is set to.

Instead of crashing the server, the only other thing that could be done is to just log a warning since at certain points where AttachmentChange is created, it is not known which clients it should be synced too yet.

Though personally I think crashing the server is fine, especially since the default limit is now 1 MiB. If modders are unknowingly syncing more than that, they should probably be forced to make a proper decision about going above it.

@modmuss50 modmuss50 merged commit f6128de into FabricMC:26.1 Jan 29, 2026
4 checks passed
@DennisOchulor DennisOchulor deleted the large-attachment-sync branch January 30, 2026 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request status: last call If you care, make yourself heard right away!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants