Add large attachment syncing#5143
Conversation
# Conflicts: # fabric-data-attachment-api-v1/src/main/java/net/fabricmc/fabric/impl/attachment/sync/AttachmentChange.java
modmuss50
left a comment
There was a problem hiding this comment.
Looks good to me, just noticed one little thing.
...achment-api-v1/src/main/java/net/fabricmc/fabric/impl/attachment/AttachmentRegistryImpl.java
Show resolved
Hide resolved
|
Also a merge conflict, should be an easy fix. |
|
Quoting @jacobsjo's comment here
Instead of crashing the server, the only other thing that could be done is to just log a warning since at certain points where Though personally I think crashing the server is fine, especially since the default limit is now 1 MiB. If modders are unknowingly syncing more than that, they should probably be forced to make a proper decision about going above it. |
This PR mainly does two things:
ClientboundAttachmentSyncPayloadto handle only one attachment. Initial syncs are sent in a bundle packet.Supersedes #4996