Move initial player attachments sync to the end of PlayerManager::onPlayerConnect#4921
Merged
modmuss50 merged 1 commit intoFabricMC:1.21.10from Oct 18, 2025
Merged
Conversation
Fuzss
added
bug
ekulxam
approved these changes
Oct 14, 2025
Syst3ms
approved these changes
Oct 14, 2025
Contributor
Syst3ms
left a comment
Syst3ms
left a comment
There was a problem hiding this comment.
LGTM. Do you think it would be possible to add a regression test for this?
apple502j
approved these changes
Oct 15, 2025
Contributor
apple502j
left a comment
apple502j
left a comment
There was a problem hiding this comment.
In another PR please update javadoc for SPCE
modmuss50
added
the
status: merge me please
modmuss50
pushed a commit
that referenced
this pull request
Oct 18, 2025
(cherry picked from commit 68e881b)
modmuss50
pushed a commit
that referenced
this pull request
Oct 18, 2025
(cherry picked from commit 68e881b)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I just stumbled across an issue with player attachment syncing. When logging in, existing attachment are never synced as the hook for that (via
ServerPlayConnectionEvents.JOINinPlayerManager::onPlayerConnect) runs too early. Presumable beforesyncedAttachmentsis set up inAttachmentTargetsMixinwhich happens fromfabric_readAttachmentsFromNbt.This can easily be fixed by invoking syncing logic at the end of
PlayerManager::onPlayerConnect, which I can confirm to work and which is also what NeoForge does.