[1.21.11] Conventional item tags for armor#4918
Merged
modmuss50 merged 2 commits intoFabricMC:1.21.11from Oct 14, 2025
Merged
Conversation
modmuss50
approved these changes
Oct 14, 2025
TelepathicGrunt
added a commit
to neoforged/NeoForge
that referenced
this pull request
Nov 22, 2025
Closes #2713 Matches fabric mostly. Fabric is missing netherite horse armor and order is a bit odd for some armors. Will be fix in a fabric pr FabricMC/fabric-api#4918
TelepathicGrunt
added a commit
to TelepathicGrunt/fabric
that referenced
this pull request
Nov 22, 2025
… entries Follow up PR for FabricMC#4918 to make Fabric match neofoge here: neoforged/NeoForge@e5a883f Armor was reordered from least protection to most protection to be consistent going forward
modmuss50
pushed a commit
that referenced
this pull request
Nov 23, 2025
… entries (#5013) Follow up PR for #4918 to make Fabric match neofoge here: neoforged/NeoForge@e5a883f Armor was reordered from least protection to most protection to be consistent going forward
shartte
pushed a commit
to neoforged/NeoForge
that referenced
this pull request
Dec 1, 2025
Closes #2713 Matches fabric mostly. Fabric is missing netherite horse armor and order is a bit odd for some armors. Will be fix in a fabric pr FabricMC/fabric-api#4918
shartte
pushed a commit
to neoforged/NeoForge
that referenced
this pull request
Dec 1, 2025
Closes #2713 Matches fabric mostly. Fabric is missing netherite horse armor and order is a bit odd for some armors. Will be fix in a fabric pr FabricMC/fabric-api#4918
shartte
pushed a commit
to neoforged/NeoForge
that referenced
this pull request
Dec 1, 2025
Closes #2713 Matches fabric mostly. Fabric is missing netherite horse armor and order is a bit odd for some armors. Will be fix in a fabric pr FabricMC/fabric-api#4918
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR expands
c:armorsto also include Wolf, Nautilus, and Horse Armor, which each have their own individual convention tags. To match against specifically humanoid armor, a new tag was added (c:armors/humanoid). Javadocs have been updated accordingly.The new structure is as follows, as suggested by @TelepathicGrunt. Fixes #4773.