Fix issues introduced by a161396#47
Merged
Player3324 merged 4 commits intoFabricMC:masterfrom Mar 1, 2026
Merged
Conversation
- Refactor to use convention plugins - Port changes from 30d9459 which have been partially lost in a161396 - Copy the Tinylog property files from the CLI module into the GUI module. This is necessary, since, unlike the original FabricMC#37, Player chose to not make the GUI module depend on the CLI module in his partial merge.
NebelNidas
changed the title
modmuss50
approved these changes
Feb 28, 2026
Member
modmuss50
left a comment
modmuss50
left a comment
There was a problem hiding this comment.
Taken a quick look at the gradle changes and it all seems fine. If it works than thats the main thing, can easily fix it later if not.
Player3324
approved these changes
Mar 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes some problems that slipped through when you were doing the partial manual merge in a161396.
@modmuss50 If you can find the time, it would be nice if you could take a quick glance at 6a7c648. It's my first time working with convention plugins, and although everything appears to be working correctly, with Gradle you can never be too sure.