This repository was archived by the owner on Mar 12, 2025. It is now read-only.
Fix some NPEs #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The one involving inner classes appeared when it encountered an anonymous inner class. `blah.blah$1` made the outerName null. I have no idea what's up with the frame analysis, but skipping null frames let everything run fine. Signed-off-by: Jadon Fowler <j@jadon.io>
|
This should be on sfPlayer1/Matcher instead |
|
Earth's last PR was merged here, so I think it's fine |
|
That's because that issue was specific to this repo |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The one involving inner classes appeared when it encountered
an anonymous inner class.
blah.blah$1made the outerName null.I have no idea what's up with the frame analysis, but skipping null
frames let everything run fine.