This repository was archived by the owner on Jun 8, 2024. It is now read-only.
Make mappings table match javadoc style and remove deprecated attributes#10
Merged
liach merged 2 commits intoFabricMC:masterfrom Dec 24, 2020
Merged
Make mappings table match javadoc style and remove deprecated attributes#10liach merged 2 commits intoFabricMC:masterfrom
liach merged 2 commits intoFabricMC:masterfrom
Conversation
liach
approved these changes
Dec 24, 2020
Collaborator
|
Interesting fact is that java 15 now uses |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the Mappings Data table style match the rest of the javadoc, and also removes unused or deprecated attributes.
Preview:
Preview HTML: AliasedBlockItem.zip (made by hand and Find and Replace) (note: this preview HTML should be placed in an existing doc at
net/minecraft/itemin order to work) (note: this preview HTML also contains the click action from #9).Uses the classes declared by javadoc itself in order to get those styles.
The removed elements are:
align="center"attributes. It's deprecated since long time ago. If wanted, usestyle="text-align: center"instead (or add it to a stylesheet matching that class)border="1"attribute. It's also deprecated<colgroup>tag. It is unused in this caseclass="literal"from the<code>elements. There are no styles nor scripted actions declared for that class.Things that could be better: In order to match what javadoc does, the last
<td>element (L84) should have thecolLastclass instead ofcolSecondfor consistency, although both classes (at least currently) have the same styling applied.Please test this by actually running the program, I've still not been able to generate mappings with it.
This conflicts with #9, since this PR changes the line where the
name="copyable"exists. Simple to fix though.