Repository navigation
Fix scene not updating when connections change - #78
Merged
vade merged 1 commit intoNov 15, 2025
Merged
Conversation
Rebuild scene from scratch in syncNodesToScene() instead of only adding new objects. Fixes issue where disconnecting nodes leaves stale geometry in the render view.
JustinMeans
marked this pull request as draft
November 15, 2025 14:05
Member
|
Ah, that tracks! Lovely fix! Totally missed this cause. Nice catch. |
Member
|
Actually, pondering this fix / bug, i suspect its also responsible for memory retain cycle in the graph code. Nice. |
Contributor
Author
|
Cool, feel free to make whatever changes you want. I wasn't sure if this was best performance-wise so changed to a draft. |
Member
|
Yea, i was / am leery of doing too much scene graph fiddling but correctness over perf (generally) at this stage of the game! |
vade
marked this pull request as ready for review
November 15, 2025 14:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Metal render view doesn't update when node connections are added/removed.
Still fixing and finding better solution, WIP.