Skip to content

Mixer Effects - #42

Merged
vade merged 2 commits into
Fabric-Project:mainfrom
tobyspark:main
Oct 8, 2025
Merged

vade merged 2 commits into
Fabric-Project:mainfrom
tobyspark:main

Conversation

@tobyspark

Copy link
Copy Markdown
Member

...aka kicking the tyres

@vade

vade commented Oct 8, 2025

Copy link
Copy Markdown
Member

Nice!

@vade

vade commented Oct 8, 2025

Copy link
Copy Markdown
Member

This looks good to me! Only thought i might have, since this is general purpose, is there a more user legible name for the SPK MXR (which i admit has a cool ring to it haha)

exited to have your contributions!

@tobyspark

Copy link
Copy Markdown
Member Author

The naming issue really stems from the fact it should be a plug-in node that I make available. Then SPK xxxxx makes more sense. For now, we suck it up as the price of contribution? Having node descriptions would help too, but that ain’t MVP.

@vade

vade commented Oct 8, 2025

Copy link
Copy Markdown
Member

Is the expectation this ships with the main editor / framework, or is this a temporary try? Maybe the thing to do is include the 3 way mixer base class which i was intending to do?

@tobyspark

tobyspark commented Oct 8, 2025 •

Copy link
Copy Markdown
Member Author

Dunno. I'm not too fussed about what ships in an alpha? Especially in the absence of some kind of plugin loading system?

@vade

vade commented Oct 8, 2025

Copy link
Copy Markdown
Member

Ok, my concern mostly stems from some legibility concerns (which, granted need to be sorted with better in app docs).

We'll figure it out!

@vade
vade merged commit 7148e24 into Fabric-Project:main Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants