New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use consistent capitalization, use one-liner installation #53

Merged

FabioAntunes merged 2 commits into FabioAntunes:master from jorgebucaran:patch-1

Dec 9, 2020

Contributor

jorgebucaran commented Nov 20, 2020 •

edited

Loading

Here's another PR! 😅

I'd strongly prefer if plugins use the same capitalization we use upstream for Fisher, not ~~fisher~~.
- I'd much prefer Fish over fish or fish-shell, but I didn't touch any of that here as you might reasonably consider that opinionated and there's nothing wrong with your current choice either.
Because Fisher installs plugins concurrently, a one-liner is more idiomatic, and faster. ✌️

jorgebucaran added 2 commits

November 21, 2020 02:14


          Use correct capitalization, improve install method

c068322


          Fix link

95ec298

Contributor Author

jorgebucaran commented Dec 9, 2020

@FabioAntunes Can we merge this? Nothing 🐟y here, I promise. 😉

FabioAntunes approved these changes

View reviewed changes

FabioAntunes merged commit 812cd8c into FabioAntunes:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet