Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix wrong instructions; clean up links #28

Merged
merged 1 commit into from
Oct 8, 2018
Merged

doc: fix wrong instructions; clean up links #28

merged 1 commit into from
Oct 8, 2018

Conversation

jorgebucaran
Copy link
Contributor

@jorgebucaran jorgebucaran commented Oct 8, 2018

  • Fix wrong instructions
  • Clean up links

cc @FabioAntunes

@jorgebucaran
Copy link
Contributor Author

jorgebucaran commented Oct 8, 2018

@FabioAntunes Anything else you want me to do here?

@FabioAntunes FabioAntunes merged commit 1cb49e0 into FabioAntunes:master Oct 8, 2018
@FabioAntunes
Copy link
Owner

Nop all good. Somehow I missed the email notification. Sorry about that.

@jorgebucaran
Copy link
Contributor Author

@FabioAntunes Sorry for not creating a new issue, but I'd wanted to ask: is there any reason why you have two arbitrary .fish files in the top-level of the project and also a functions/ directory? Why the inconsistency?

@FabioAntunes
Copy link
Owner

Nothing special, the functions folder was added later with a subset of functions to be used by the user and the ones on the top level are kind of private functions for internal use. I will move all the functions to the functions folder since the separation doesn't make any sense at all.

@jorgebucaran
Copy link
Contributor Author

Sounds good! 👍

@FabioAntunes
Copy link
Owner

@jorgebucaran done, thanks for noticing that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants