Ability to set NVM_DIR and nvm_preffix separately in configuration #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed if you have installed NVM using Brew. Brew would install NVM into /usr/local/Cellar/nvm/%nvm_version%/nvm.sh and ask to set $NVM_DIR to ~/.nvm. Hence user is required to set nvm_prefix separately from NVM_DIR.
FabioAntunes
approved these changes
Feb 18, 2018
|
Thanks for the PR, everything seems OK. But I would just like to test it before merging. Will be doing that later today. |
functions/nvm.fish
Outdated
| @@ -4,7 +4,7 @@ function nvm | |||
| return | |||
| end | |||
| set -q NVM_DIR; or set -gx NVM_DIR ~/.nvm | |||
| set -g nvm_prefix $NVM_DIR | |||
| set -q nvm_prefix; or set -g nvm_prefix $NVM_DIR | |||
There was a problem hiding this comment.
could you just add the -gx so it gets exported to the child processes?
set -q nvm_prefix; or set -gx nvm_prefix $NVM_DIR
There was a problem hiding this comment.
Sorry, my bad.
Added -gx parameters.
There was a problem hiding this comment.
Sorry, my bad.
Added -gx paramaters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ability to set NVM_DIR and nvm_preffix separately in configuration
This is needed if you have installed NVM using a custom path but still using ~/.nvm as NVM_DIR. For example this is the case when using brew to install NVM on MacOS.
Brew would install NVM into /usr/local/Cellar/nvm/%nvm_version%/nvm.sh and ask to set $NVM_DIR to ~/.nvm. Hence user is required to set nvm_prefix separately from NVM_DIR.