Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

original search fix #181

Merged
merged 2 commits into from
Jan 2, 2023
Merged

original search fix #181

merged 2 commits into from
Jan 2, 2023

Conversation

bla0r
Copy link
Contributor

@bla0r bla0r commented Jan 1, 2023

this commit fixes the original search and comin' up with the following options:

  • IMDB_EXACT_SEARCH = true
  • IMDB_USE_SENSITIVITY = false (highest match will returned)

@FabianBeiner
Copy link
Owner

Thanks, @bla0r. :) However, before I merge:

Wouldn't it make more sense to only have one of those options? E.g., only the “exact search” one and the other as fall back? Because I'm pretty sure someone will get confused and disable or enable both.

@bla0r
Copy link
Contributor Author

bla0r commented Jan 2, 2023

yeah makes sense. will do it.

@bla0r
Copy link
Contributor Author

bla0r commented Jan 2, 2023

fixed :-)

@FabianBeiner FabianBeiner merged commit a48d43b into FabianBeiner:master Jan 2, 2023
@FabianBeiner
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants