Fix #520 - region menu title dataset status #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you add tests (unit/e2e) and create a release doc (v2.2.2.md)? |
|
Sure, thanks for remind |
xgui3783
reviewed
May 27, 2020
xgui3783
reviewed
May 27, 2020
xgui3783
reviewed
May 27, 2020
|
actually don't worry about actually writing the unit tests, just add the spec files, and descriptions. Add a TODO. Any component importing store running unit tests seems to run into an error, and I need to find out why |
|
The branch is ready to merge |
xgui3783
reviewed
May 27, 2020
fsdavid
force-pushed
the
bug_fix_520_region_menu_title_staus
branch
from
41836a3
to
ac27c15
Compare
xgui3783
reviewed
May 28, 2020
xgui3783
reviewed
May 28, 2020
|
LGTM. I will pull and test locally, once that's done, I will merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.