Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: fix annotation space bug #1308

Merged
merged 2 commits into from
Apr 19, 2023
Merged

bugfix: fix annotation space bug #1308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f518c1b
bugfix: fix annotation space bug
xgui3783 Apr 19, 2023
e167e9b
fix lint
xgui3783 Apr 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/releases/v2.10.1.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

- fsaverage on change variant, showing multiple meshes
- fsaverage erroneous URL encoding of selected region
- some annotations no longe rwork properly

## Behind the scenes

Expand Down
2 changes: 1 addition & 1 deletion src/state/annotations/selectors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export const spaceFilteredAnnotations = createSelector(
selectStore,
atlasSelectionSelectors.selectStore,
(annState, atlasSelState) => annState.annotations.filter(ann => {
const spaceId = atlasSelState.selectedTemplate['@id']
const spaceId = atlasSelState.selectedTemplate.id
if (ann['openminds']) {
return (ann as Annotation<'openminds'>).openminds.coordinateSpace['@id'] === spaceId
}
Expand Down
4 changes: 2 additions & 2 deletions src/viewerModule/threeSurfer/threeSurferGlue/threeSurfer.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ type THandleCustomMouseEv = {
latLblIdxReg: TLatIdxReg
meshVisibility: {
label: string
visible: boolean,
visible: boolean
mesh: TThreeGeometry
}[]
}
Expand Down Expand Up @@ -170,7 +170,7 @@ export class ThreeSurferGlueCmp implements IViewer<'threeSurfer'>, AfterViewInit
map(v => {
const returnVal: {
label: string
visible: boolean,
visible: boolean
mesh: TThreeGeometry
}[] = []
for (const lat in v) {
Expand Down