Skip to content

Android CI support#436

Open
Velaron wants to merge 5 commits into
FWGS:masterfrom
Velaron:android-ci
Open

Android CI support#436
Velaron wants to merge 5 commits into
FWGS:masterfrom
Velaron:android-ci

Conversation

@Velaron

@Velaron Velaron commented Feb 10, 2024

Copy link
Copy Markdown
Member

I think APKs should be signed with something though, as without a signature they are hard to install

@nekonomicon

Copy link
Copy Markdown
Member

I think APKs should be signed with something though, as without a signature they are hard to install

Nah, I'm against distributing random key signed builds.
And you probably didn't understand me.
CI needed for release builds.
Our hlsdk fork is stable enough, so there no reason to make debug builds.
And IMHO good testing environment - any linux distro compiled with clang or even better *BSD.

@Velaron

Velaron commented Feb 11, 2024

Copy link
Copy Markdown
Member Author

I don't see anything wrong with signing APKs, without a signature users will have to sign it by themselves or use ADB, which would require a PC and some knowledge. Then they will distribute these signed APKs through random chats and websites, because that is what happens. You can use your oersonal debug.keystore or official keys I use in the Play Store.
As for the second point, in my experience Android has a lot of unique bugs and crashes that I can't reproduce anywhere, but debug was just a typo.

@a1batross

a1batross commented Feb 11, 2024 via email

Copy link
Copy Markdown
Member

@Velaron

Velaron commented Feb 13, 2024

Copy link
Copy Markdown
Member Author

The question is, do I add my debug signature I use in some repos, or the release signature used in Google Play?

@FreeSlave

Copy link
Copy Markdown
Member

Github actions support secrets. Why not use them if you need some private key?

@Velaron

Velaron commented Feb 13, 2024

Copy link
Copy Markdown
Member Author

Yeah, that's what I plan to use for GP signatures

@a1batross

Copy link
Copy Markdown
Member

The question is, do I add my debug signature I use in some repos, or the release signature used in Google Play?

It doesn't matter to me. You can as well just make a standalone repo (as it might be shared with other projects, like engine) and fetch it using wget or curl.

@a1batross

Copy link
Copy Markdown
Member

Github actions support secrets. Why not use them if you need some private key?

this is good for storing passwords. If you encode a keystore into a text, it probably needs to be stored somewhere. I don't think apksigner knows how to read from stdin.

@Velaron

Velaron commented Feb 13, 2024

Copy link
Copy Markdown
Member Author

I upload the key as base64 and then it's decoded back into a file, I already use this method on my mods

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants