Rework mesh implementation #611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Sep 1, 2022
Closed
…ature/525-rework-mesh
This reverts commit b398169.
…omponents-can-use-dynamic-meshes Feature/622 pointcloudcomponents can use dynamic meshes
…pointcloud-doesnt-allow-to-modify-the-changesurf-methods
…ctpointcloud-doesnt-allow-to-modify-the-changesurf-methods Feature/624 surfaceeffectpointcloud doesnt allow to modify the change surf methods
ASPePeX
approved these changes
Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #605
Closes: #525
Closes: #456
Closes: #396
Closes: #622
Implemented new mesh backing field logic which registeres each and every change inside the data
Update GPU data once per frame via
MeshManager.cs(if requested, defaulttrue)Prepared the possibility to track changed indices/index ranges (not yet completely implemented)
Re-Calculate the AABB for each mesh, each frame (only if necessary)
Use
ReadOnlySpan<T>where possible, pass only references to the mesh data until we arrive at theGLmethodsUpdate all triangles from
ushorttouint(Android, Blazor, Desktop), no mesh triangles limitation toushort.maxanymoreFollow-ups: implement and track each changed index range, implement the possibility to switch between
dynamic(CPU and GPU data present)static(CPU data isreadonly),GPUMesh(no more CPU data) mesh implementation