Feature/591 dispose point cloud component #595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from inside the finalizer
…ject that holds unmanaged resources a
4 tasks
wrestledBearOnce
requested changes
Aug 22, 2022
There was a problem hiding this comment.
SolarLint says: revisit the abstract class Effect and either implement the IDisposable-pattern there (do not use abstract), or move the interface implementation to the SurfaceEffectBase class.
Everything else looks and works fine for me.
Perhaps we should measure the impact of the event after each frame, hopefully this is negligible.
…e-pointCloudComponent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
EndOfFrameevent toRenderCanvasIDisposableimplementationsCloses #591
Closes #584 due to IDisposable changes
Closes #607