Skip to content

Feature/RemoveSceneConverterNullId #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 24, 2021
Merged

Feature/RemoveSceneConverterNullId #342

merged 4 commits into from
Sep 24, 2021

Conversation

ASPePeX
Copy link
Member

@ASPePeX ASPePeX commented Sep 22, 2021

closes #286

@ASPePeX ASPePeX added enhancement inherited/legacy burdens Old stuff which is nearly finished and/or buggy and has to be finished eventually labels Sep 22, 2021
@ASPePeX ASPePeX added this to the Release 0.11 milestone Sep 22, 2021
@ASPePeX ASPePeX linked an issue Sep 22, 2021 that may be closed by this pull request
Make 'id' a mandatory parameter in FusSceneConverter.ConvertFrom() #286
Closed
RedImp1470
RedImp1470 reviewed Sep 23, 2021
View reviewed changes
Copy link
Member

@RedImp1470 RedImp1470 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ConvertFrom is missing the comment for "id" (empty param).

@ASPePeX ASPePeX merged commit 48638ea into develop Sep 24, 2021
@ASPePeX ASPePeX deleted the feature/RemoveSceneConverterNullId branch September 24, 2021 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RedImp1470 RedImp1470 RedImp1470 approved these changes

@wrestledBearOnce wrestledBearOnce Awaiting requested review from wrestledBearOnce

@griestopf griestopf Awaiting requested review from griestopf

Assignees
No one assigned
Labels
enhancement inherited/legacy burdens Old stuff which is nearly finished and/or buggy and has to be finished eventually
Projects
None yet
Milestone
Release 0.11
Development

Successfully merging this pull request may close these issues.

Make 'id' a mandatory parameter in FusSceneConverter.ConvertFrom()
2 participants
@ASPePeX @RedImp1470