Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Competition maps (and map bugfixes) #179

Merged
merged 10 commits into from
Jul 26, 2020
Merged

Competition maps (and map bugfixes) #179

merged 10 commits into from
Jul 26, 2020

Conversation

SijmenHuizenga
Copy link
Member

@SijmenHuizenga SijmenHuizenga commented Jul 24, 2020

Built the base for the competition maps!

Note to FSOnline participants: The tracks in here are not the competition tracks.

image

These maps are still missing weather conditions and sponsor banners. Will be added later.

…slations of the cones in the cone spline
…abled physics simulation on right front cone
@SijmenHuizenga SijmenHuizenga changed the title Competition maps Competition maps (and map bugfixes) Jul 24, 2020
@SijmenHuizenga SijmenHuizenga linked an issue Jul 24, 2020 that may be closed by this pull request
Copy link
Collaborator

@Riliano Riliano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, the new maps look and play nice.

Only thing about the fix for #125 is that now there will be a warning about a StaticMeshActor(the parent of the cones) with no StaticMesh selected. From what I've read this won't cause any actual problems for us, but it might be annoying.

@SijmenHuizenga
Copy link
Member Author

Thanks for reviewing @Riliano!

Before merging I will try to get the StaticMeshActor warning away as I agree it isn't that nice :) Maybe I can attach the trigger line as the primary StaticMesh.

@Riliano
Copy link
Collaborator

Riliano commented Jul 25, 2020

Well I think there are two options:

  1. (correct) would be to change the parent of all cones from StaticMeshActor to a simple Actor. I tried that but the conversion didn't go smoothly, but I want to try again.

  2. (meh) would be to just add a simple transparent material to the parent, just ot get the warning away.

It wont really impact performance much either way (the reason for the warning) since this entity exists once per map anyway.

@SijmenHuizenga
Copy link
Member Author

@Riliano I managed to convert the startfinishline into a simple actor.

I also fixed some bug where cones were counted twice and where (in spectator mode) the timer ran twice.

@SijmenHuizenga SijmenHuizenga merged commit 45cd8a2 into master Jul 26, 2020
@SijmenHuizenga SijmenHuizenga deleted the competition-map branch July 26, 2020 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants