Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROS bridge attempts to get data from sensors even if not present in settings #326

Closed
mateusz-lichota opened this issue Sep 3, 2022 · 0 comments · Fixed by #339
Closed
Labels
bug Something isn't working

Comments

@mateusz-lichota
Copy link
Contributor

Currently, the ROS bridge assumes that GSS and GPS sensors will always be configured in the settings, and uses hardcoded sensor names to make RPC calls, which fail if those sensors are not present in settings. This behaviour should be changed to how it works with lidar, namely, having an array of the sensors of each type and making separate publishers (potentially 0 of them) for each.

Encountered this bug when I removed the GPS sensor from settings.json and the ROS bridge started printing errors about the RPC call failing:

[fsds_ros2_bridge-23] Exception raised by the API while getting gps data:
[fsds_ros2_bridge-23] rpclib: function 'getGpsData' (called with 2 arg(s)) threw an exception. The exception contained this information: No gps with name Gps exist on vehicle.
[fsds_ros2_bridge-23] error
@mateusz-lichota mateusz-lichota added the bug Something isn't working label Sep 3, 2022
@wouter-heerwegh wouter-heerwegh added this to the Release v2.2.0 milestone Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants