debian: add --enable-werror

[idryzhov]

We don't want to build a package when we have build warnings, right?

Signed-off-by: Igor Ryzhov iryzhov@nfware.com

[donaldsharp]

I'm pretty sure this is a standard no from a debian perspective.... I've tried to turn this on in the past and got told by some of the more debian minded people that is not the way to go. But we'll see this time

[NetDEF-CI]

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-765/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Ubuntu 18.04 ppc64le build: Failed (click for details)

Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-765/artifact/U1804PPC64LEBUILD/ErrorLog/ Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-765/artifact/U1804PPC64LEBUILD/config.status/config.status Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-765/artifact/U1804PPC64LEBUILD/config.log/config.log.gz Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-765/artifact/U1804PPC64LEBUILD/frr.xref.xz/frr.xref.xz Ubuntu 18.04 ppc64le build: No useful log found

Ubuntu 18.04 arm7 build: Failed (click for details)

Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-765/artifact/U18ARM7BUILD/ErrorLog/ Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-765/artifact/U18ARM7BUILD/config.log/config.log.gz Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-765/artifact/U18ARM7BUILD/config.status/config.status Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-765/artifact/U18ARM7BUILD/frr.xref.xz/frr.xref.xz Ubuntu 18.04 arm7 build: No useful log found

Ubuntu 16.04 arm7 build: Failed (click for details)

Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-765/artifact/CI101BUILD/config.status/config.status Ubuntu 16.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-765/artifact/CI101BUILD/config.log/config.log.gz Ubuntu 16.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-765/artifact/CI101BUILD/ErrorLog/ Ubuntu 16.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-765/artifact/CI101BUILD/frr.xref.xz/frr.xref.xz Ubuntu 16.04 arm7 build: No useful log found

Ubuntu 16.04 i386 build: Failed (click for details)

Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-765/artifact/U1604I386/ErrorLog/ Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-765/artifact/U1604I386/config.status/config.status Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-765/artifact/U1604I386/config.log/config.log.gz Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-765/artifact/U1604I386/frr.xref.xz/frr.xref.xz Ubuntu 16.04 i386 build: No useful log found

Ubuntu 18.04 i386 build: Failed (click for details)

Ubuntu 18.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-765/artifact/U18I386BUILD/frr.xref.xz/frr.xref.xz Ubuntu 18.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-765/artifact/U18I386BUILD/config.log/config.log.gz Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-765/artifact/U18I386BUILD/config.status/config.status Ubuntu 18.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-765/artifact/U18I386BUILD/ErrorLog/ Ubuntu 18.04 i386 build: No useful log found

Successful on other platforms/tests

• Ubuntu 18.04 arm8 build
• Ubuntu 20.04 amd64 build
• Debian 9 amd64 build
• CentOS 8 amd64 build
• Fedora 29 amd64 build
• Debian 10 amd64 build
• CentOS 7 amd64 build
• Debian 11 amd64 build
• Ubuntu 18.04 amd64 build
• FreeBSD 11 amd64 build
• NetBSD 8 amd64 build
• FreeBSD 12 amd64 build
• Ubuntu 16.04 arm8 build
• Ubuntu 16.04 amd64 build
• OpenBSD 6 amd64 build

[idryzhov]

lol, so we actually have build warnings on ppc, i386 and arm7 and CI doesn't catch them.
@mwinter-osr should we do anything about that?

[donaldsharp]

@idryzhov let's just fix them up. I'll take a few of them now.

[LabN-CI]

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/9823 adf8f96
Date	10/13/2021
Start	13:52:49
Finish	14:19:14
Run-Time	26:25
Total	1813
Pass	1813
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2021-10-13-13:52:49.txt
Log	autoscript-2021-10-13-13:54:03.log.bz2
Memory	518 516 412

For details, please contact louberger

[eqvinox]

@idryzhov package builds for distros should never ever use -Werror. Rationale: when the distro upgrades the compiler, there will likely be some new warnings, and then the build fails even though the package itself didn't change. This is particularly bad for automated rebuilds, i.e. when Debian upgrades GCC or glibc, they rebuild almost everything. For any failure during that process, they're going through their processes to figure out if it's a compiler/glibc bug.

[eqvinox]

strict NAK

[idryzhov]

@eqvinox ok, but let's please figure out why ppc, i386 and arm7 CI didn't catch the errors.