Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More struct thread null #9763

Merged
merged 4 commits into from
Oct 12, 2021
Merged

More struct thread null #9763

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1a8e5ae
tests: Do not explicitly set the thread pointer to NULL
ton31337 Oct 7, 2021
3063485
ospfd: Do not explicitly set the thread pointer to NULL
ton31337 Oct 7, 2021
ae84497
isisd: Do not explicitly set the thread pointer to NULL
ton31337 Oct 7, 2021
d573b8f
ospf6d: Do not explicitly set the thread pointer to NULL
ton31337 Oct 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
tests: Do not explicitly set the thread pointer to NULL 
FRR should only ever use the appropriate THREAD_ON/THREAD_OFF
semantics.  This is espacially true for the functions we
end up calling the thread for.

Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
  • Loading branch information
@ton31337
ton31337 committed Oct 8, 2021
commit 1a8e5aea78aba2d38de0e7bc7bdbe0e4b5a6960d
1 change: 0 additions & 1 deletion tests/lib/test_timer_correctness.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,6 @@ int main(int argc, char **argv)

XFREE(MTYPE_TMP, timers[index]->arg);
thread_cancel(&timers[index]);
timers[index] = NULL;
timers_pending--;
}

Expand Down
1 change: 0 additions & 1 deletion tests/lib/test_timer_performance.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ int main(int argc, char **argv)

index = prng_rand(prng) % SCHEDULE_TIMERS;
thread_cancel(&timers[index]);
timers[index] = NULL;
}

monotime(&tv_stop);
Expand Down